-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove macOS universal build #217
base: main
Are you sure you want to change the base?
Conversation
- Release separate binaries for x86_64 and aarch64
I never figured out a way to test this without actually pushing to the repository. Creating tags should be fine, as it only creates a "draft release" that we don't need to publish. I think you should be able to see draft releases with your repository permissions. |
@bkolobara Every thing looks good! Can You try out the new binaries on macOS, to see if the problems format are gone? After we can delete the draft builds. PS. Ignore the deny checks 😄 |
It works! But it also bundles the whole I just remembered that we also have a hombrew formula that is automatically updated when a release is triggered. I couldn't find examples of formulas that have both arm and x64 binaries in it. With the universal build we always pointed to the same, but am unsure how it would work now. |
Ok, great catch I'll remove the directory structure! Also I'll check what we can do about hombrew and how we can improve release there. |
I've fixed the directory structure when we package macOS builds. Also I've checked some of the most popular rust project and how they are installed using Homebrew. Most of them are using Here are some of the examples: In short all their formula depend on |
This was done in order to fix issues with existing universal binary which does not work on some macOS systems.
Some people reported the following issue
exec format error: lunatic
.@bkolobara I'm not sure how to test this without creating a tag?