This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
use the cache to retrieve imported less files #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed a bug in the code which detects if less files have been modified.
The code gets the imports by reading the less file, then stores the imports in the cache. At the next request, it reads the imports from the cache, but ignores the result, and thus re-reads the file.
On my MacBookPro with a SSD, this leads to times of around 150 ms. to return a 304 - Not Modified response. After the fix, we're down to 3 ms. On a low-end web server with a regular disk, the times are about 1.5 seconds for each 304, instead of a few milliseconds.
Note that there is another bug, not fixed by this PR: the code stores new entries in the cache every time a file is modified, but it never removes the old entries.