🛠️ Fix compiling and multiline selection issue for IDE 2024 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lunakoly |
lunakoly
requested changes
Jun 8, 2024
|
Also, I would appreciate if you reworded the commits to the style of the previous ones in |
akhilerm
changed the title
akhilerm
changed the title
Sorry for that. Missed it while pushing the fix. Have edited and pushed the commits. |
lunakoly
requested changes
Jun 11, 2024
- fix compiling on newer versions of IDEA Signed-off-by: Akhil Mohan <[email protected]>
- latest version of intellij reports incorrect line numbers when directly using selectionModel. It has been modified to use editor.document which works on both old (2021) and new (2024) IDE versions Signed-off-by: Akhil Mohan <[email protected]>
- update changelog - update plugin version to 1.0.9 Signed-off-by: Akhil Mohan <[email protected]>
lunakoly
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES TO REVIEWER:
I have tested the multiline selection on IC 2021.1, IC 2024.1.2 and GO 2024.1.2. So not exactly sure which version of IDE broke the compatibility. The compiling was also tried on the above mentioned versions.