Lumberjack disabled 3x #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support dashes and underscores in CSS selectors
Also fix SVGElement's [selector: appliesTo: specificity:] to support multiple classes in one className.
Support visibility:hidden and display:none
… their outdated example
Create custom logging context for SVGKit
fix crash on devices with iOS8+ when calling [super renderInContext:]
Update SVGGradientLayer.m
Defines PPI for iPod touch 6.
Added iPhone 6s and 6s Plus support to avoid crash.
NB: merging experimentally - looks OK on visual scan, but needs testing -- adamgit. Support for packaging as iOS frameworks
Adding line on how to setup svgkit with cocoapods, after seeing two github issues (SVGKit#380 & SVGKit#378 ) with this as the solution.
…e layer class (layer-backed or layer-hosting)
…SubstringsInRange:options:usingBlock:], since that method tokenizes strings with hyphens in them into separate strings, causing the method to fail if there is at least one hyphen in the selector name. Add a sample that illustrates the problem. Without the change, the two half-circles in the bottom-right corner are filled with black (incorrect), whereas with the change, they're filled with bright red (correct). Fixes SVGKit#600
…efore source usage
…ge element URL is invalid. Fix issue of text element which does not support percent value for `x`, `y`
All init method should call `populateFromImage` to correctly setup the layer class (layer-backed or layer-hosting)
…ents. Don't need to recursive check and hack for that transform
…r_solution Use a better solution to solve macOS's flip of <image> && <text> contents
Use NSScanner to tokenize class names instead of -[NSString enumerate…
Don't throw exception out side the framework, using the error check before source usage
The `pixelsPerInchForCurrentDevice` didn't had value for iPads with prefix iPad8
…neration_iPad_Pro fix: app crashed on iPad Pro 3rd generation
* # SVGElement position issue addressed. - Considered origin x & y for svg element. * - Set position value(X&Y) to initial value i.e 0. - As per documentation(https://www.w3.org/TR/SVG/geometry.html#XProperty) initial value should 0 * - Now nil check is not required. * - Discard, not required changes. * - Again formatting. * - Position value corrected.
…d project file level disabling. (SVGKit#615) This fixes the iOS targets, which did not have asserts disabled for the Release configuration.
* add init methods that take a cacheKey parameter * move clear cache logic to clear cache, use cache key or name * remove call to memory warning notification
Fixes `github "SVGKit/SVGKit"`. Carthage can't deject `github 'SVGKit/SVGKit'`
In macOS, the SVGKFastImageView may not have a "layer" property value when its "image" property is set. When deallocated, the SVGKFastImageView may have a _NSViewBackingLayer set to its "layer" property. We must avoid calling "removeObserver:" on the layer unless "wantsLayer" is being used. Otherwise, the application will crash when trying to remove "self" as an observer when it isn't actually observing.
… of static variable. Also fix the protocol method implementation, which should return NSArray instead of NSSet (SVGKit#642)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.