Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for all element. #147

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Added support for all element. #147

merged 3 commits into from
Mar 19, 2024

Conversation

lkirkwood
Copy link
Contributor

Adapted from #112.

@lkirkwood
Copy link
Contributor Author

Is there something that needs changing in this to get it reviewed?

@MarcusElg
Copy link

I also needed support for xs:all. I tried this pr and it did work as expected so it would be nice to get this merged :) @DmitrySamoylov

@DmitrySamoylov
Copy link
Contributor

Sorry for the delay. Please, add a test as described in https://github.com/lumeohq/xsd-parser-rs/blob/main/xsd-parser/tests/README.md

@DmitrySamoylov DmitrySamoylov self-requested a review March 12, 2024 11:36
@lkirkwood
Copy link
Contributor Author

I have added the tests as requested :)
Let me know if you need anything else for this

@DmitrySamoylov
Copy link
Contributor

Please, also run rustfmt ;) Not sure if you receive notifications for failed builds.

@lkirkwood
Copy link
Contributor Author

Apologies - fixed.

@DmitrySamoylov DmitrySamoylov merged commit 0834ded into lumeohq:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitrySamoylov DmitrySamoylov DmitrySamoylov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkirkwood @MarcusElg @DmitrySamoylov