forked from getsentry/sentry-rust
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade actix-web and actix-service #1
Open
Kbman99
wants to merge
33
commits into
lumeohq:master
Choose a base branch
from
Kbman99:upgrade_actix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes parsing of backtraces that have both line and column numbers
…y#344) The generic `anyhow::msg` will just `Debug::fmt` the `String` that you feed it, which results in Error types with leading quotes.
…y fixes (getsentry#345) Some integrations do not work out of the box, but this isn't noted anywhere except in the integration's own documentation. Mentioning gotchas with features when they are introduced to the user should help out with this.
APIs hidden behind features can now be viewed on docs.rs! All feature-gated modules and structs should be annotated with a note that mentions the specific feature flag needed to use the corresponding API. This primarily fixes a linter warning regarding a link to a nonexistent integration which was gated behind a feature. There are other small fixes as well, mostly just hooking up links that weren't assigned destinations. While the doc feature is considered unstable, we're taking advantage of the fact that docs are built with nightly by default.
This way, cargo will not verify the versions when publishing, removing the need to use `cargo-hack` for publishing.
This also removes the need to manually box the argument to `add_event_processor`.
meta: Add two missing breaking changes to changelog
Kbman99
force-pushed
the
upgrade_actix
branch
from
November 12, 2021 23:20
3b8b3d2
to
9418c68
Compare
The latest actix-service is now stable and actix-web has since had some additional work added to the beta branch. This adds those new dependencies.
Kbman99
force-pushed
the
upgrade_actix
branch
from
November 12, 2021 23:26
9418c68
to
6dbf966
Compare
DmitrySamoylov
force-pushed
the
master
branch
from
December 20, 2021 10:43
462511c
to
c7d5374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest actix-service is now stable and actix-web has since had some
additional work added to the beta branch. This adds those new
dependencies.