docs(FormElement): add docs & refactor component structure #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zettca
requested review from
plagoa and
francisco-guilherme
and removed request for
a team
zettca
changed the title
zettca
commented
Nov 27, 2024
| @@ -123,79 +79,10 @@ export default function Demo() { | |||
| } | |||
| ``` | |||
|
|
|||
| ### External error message | |||
There was a problem hiding this comment.
this is a awkward example to add for each form component. it should be added in a complete form example/template instead
There was a problem hiding this comment.
Maybe we should add a callout on each form component documentation page to direct people to the FormElement page (not just on the related components section)
plagoa
approved these changes
Nov 28, 2024
francisco-guilherme
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HvFormElementto root, aligning with other components (this is needed for the currentnextradoc generation)HvLabel,HvWarningText, etc. asHvFormElement's sub-components, keeping alignment with other componentsHvFormElement's contexts (and remove/refactor redundant.Provider.Consumercomponents)Warning
please rebase, don't squash