Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ToggleButton usage #4429

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: ToggleButton usage #4429

merged 1 commit into from
Nov 15, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Nov 13, 2024 •
edited
Loading

  • allow aria-pressed=false in HvButton & reuse it in HvToggleButton
  • refactor TimePicker
    • use HvButton instead of HvToggleButton (aria-pressed doesn't make sense)
    • use HvBaseInput instead of HvInput (we don't need HvInput's features)
    • update deprecated state.validationState API

@github-actions github-actions bot temporarily deployed to uikit/pr-4429 November 13, 2024 18:49 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4429 November 13, 2024 18:50 Destroyed
@zettca zettca marked this pull request as ready for review November 13, 2024 19:13
@zettca zettca requested a review from a team as a code owner November 13, 2024 19:13
@zettca zettca requested review from plagoa and MEsteves22 and removed request for a team November 13, 2024 19:13
@zettca zettca changed the title chore: fix ToggleButton usage refactor: ToggleButton usage Nov 13, 2024
@zettca zettca changed the title refactor: ToggleButton usage fix: ToggleButton usage Nov 13, 2024
@github-actions github-actions bot temporarily deployed to uikit/pr-4429 November 13, 2024 19:18 Destroyed
@zettca zettca merged commit 3aaa625 into master Nov 15, 2024
12 checks passed
@zettca zettca deleted the fix/stuff branch November 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plagoa plagoa plagoa approved these changes

@MEsteves22 MEsteves22 Awaiting requested review from MEsteves22 MEsteves22 is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zettca @plagoa