Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): update error color #4428

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix(Input): update error color #4428

merged 1 commit into from
Nov 15, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Nov 13, 2024

  • update invalid/error to negative_120
  • fix(WarningText): use span for label & refactor colors

@github-actions github-actions bot temporarily deployed to uikit/pr-4428 November 13, 2024 18:14 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4428 November 13, 2024 18:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4428 November 13, 2024 18:51 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4428 November 13, 2024 18:52 Destroyed
fix(WarningText): use span for label & refactor colors

render message to DOM, allowing it to be displayed by overriding the
styles. element is still invisible to the a11y tree

style(form): update invalid/error to negative_120
@github-actions github-actions bot temporarily deployed to uikit/pr-4428 November 13, 2024 19:12 Destroyed
@zettca zettca marked this pull request as ready for review November 14, 2024 10:22
@zettca zettca requested a review from a team as a code owner November 14, 2024 10:22
@zettca zettca requested review from plagoa and francisco-guilherme and removed request for a team November 14, 2024 10:22
@zettca zettca merged commit d80db47 into master Nov 15, 2024
12 checks passed
@zettca zettca deleted the feat/warning-text branch November 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants