Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: style improvements #4412

Merged
merged 1 commit into from
Nov 11, 2024
Merged

docs: style improvements #4412

merged 1 commit into from
Nov 11, 2024

Conversation

francisco-guilherme
Copy link
Contributor

No description provided.

@francisco-guilherme francisco-guilherme requested a review from a team as a code owner November 4, 2024 19:37
@francisco-guilherme francisco-guilherme requested review from zettca and MEsteves22 and removed request for a team November 4, 2024 19:37
@github-actions github-actions bot temporarily deployed to uikit/pr-4412 November 4, 2024 21:53 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4412 November 4, 2024 21:53 Destroyed
Copy link
Member

@zettca zettca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small notes that can be reviewed later
feel free to merge

apps/docs/src/components/Footer.tsx Show resolved Hide resolved
Comment on lines +7 to +9
{ label: "Get Started", href: "/documentation/get-started" },
{ label: "Contribute", href: "/documentation/contribute/" },
{ label: "Changelog", href: "/documentation/changelog/" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links are broken in the deployments/production

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fix them later

Comment on lines +76 to +78
>
Explore components <span className="ml-2" />
<ArrowRight />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to find a way to be able to use any icon (including HV's), and the spacing just work

Suggested change
>
Explore components <span className="ml-2" />
<ArrowRight />
endIcon={<ArrowRight />}
>
Explore components

apps/docs/src/pages/components/avatar.mdx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to uikit/pr-4412 November 11, 2024 11:34 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4412 November 11, 2024 11:34 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4412 November 11, 2024 12:05 Destroyed
@francisco-guilherme francisco-guilherme merged commit 1900666 into master Nov 11, 2024
11 checks passed
@francisco-guilherme francisco-guilherme deleted the docs-styles branch November 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants