Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Section actions alignment & Panel borderRadius #4404

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Oct 30, 2024

  • change HvPanel to inherit borderRadius
  • fix HvSection actions alignment (right padding, absolute > flex)
    • also rename spaceTop > hasHeader
  • improve theme.spacing calc for 0 case value (0 instead of calc(0 * var(--theme-space-unit)))
  • improve capitalize value inference, to get rid of some as casts

image

image

@github-actions github-actions bot temporarily deployed to uikit/pr-4404 October 30, 2024 10:59 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4404 October 30, 2024 10:59 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4404 October 30, 2024 11:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4404 October 30, 2024 11:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4404 October 30, 2024 11:35 Destroyed
@zettca zettca marked this pull request as ready for review October 30, 2024 11:44
@zettca zettca requested a review from a team as a code owner October 30, 2024 11:44
@zettca zettca requested review from plagoa and francisco-guilherme and removed request for a team October 30, 2024 11:44
@francisco-guilherme francisco-guilherme merged commit 67ac81f into master Nov 3, 2024
12 checks passed
@francisco-guilherme francisco-guilherme deleted the fix/stuffx branch November 3, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants