Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): calendar spacing #4291

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix(DatePicker): calendar spacing #4291

merged 2 commits into from
Aug 21, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Aug 21, 2024

Related to #4290 but does not resolve it.

HvDatePicker requires lots of vertical height to be fully visible in rangeMode or when actions are present. After inspection, I noticed it's occupying more space than it needs to, due to:

  • excessive padding of CalendarHeader input (md instead of sm)
  • additive padding between CalendarHeader input and ComposedNavigation
  • fixed heights and widths instead of dynamic according to content

also fixed DS3's HvButton minWidth specificity, which was causing issues

@zettca zettca requested a review from a team as a code owner August 21, 2024 14:21
@zettca zettca requested review from plagoa and francisco-guilherme and removed request for a team August 21, 2024 14:21
@github-actions github-actions bot temporarily deployed to uikit/pr-4291 August 21, 2024 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4291 August 21, 2024 14:30 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4291 August 21, 2024 17:37 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4291 August 21, 2024 17:38 Destroyed
@zettca zettca merged commit 7afe152 into master Aug 21, 2024
13 checks passed
@zettca zettca deleted the fix/stuff branch August 21, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants