test(decorators): add test case for nullify custom method decorators

luketanner · Feb 1, 2019 · a86432c · a86432c
1 parent 3e5ea9d
commit a86432c
Showing 1 changed file with 38 additions and 5 deletions.
diff --git a/tests/functional/resolvers.ts b/tests/functional/resolvers.ts
@@ -1082,14 +1082,27 @@ describe("Resolvers", () => {
     let queryRoot: any;
     let queryContext: any;
     let queryInfo: any;
+    let descriptorEvaluated: boolean;
+
+    function DescriptorDecorator(): MethodDecorator {
+      return (obj, methodName, descriptor: any) => {
+        const originalMethod: Function = descriptor.value;
+        descriptor.value = function() {
+          descriptorEvaluated = true;
+          return originalMethod.apply(this, arguments);
+        };
+      };
+    }
 
     // helpers
     function generateAndVisitComplexMethod(maximumComplexity: number): ValidationContext {
-      const query = `query {
-                          sampleQuery {
-                          complexResolverMethod
-                          }
-                        }`;
+      const query = /* graphql */ `
+        query {
+          sampleQuery {
+            complexResolverMethod
+          }
+        }
+      `;
       const ast = parse(query);
       const typeInfo = new TypeInfo(schema);
       const context = new ValidationContext(schema, ast, typeInfo);
@@ -1105,6 +1118,7 @@ describe("Resolvers", () => {
       queryRoot = undefined;
       queryContext = undefined;
       queryInfo = undefined;
+      descriptorEvaluated = false;
     });
 
     beforeAll(async () => {
@@ -1216,6 +1230,12 @@ describe("Resolvers", () => {
           return true;
         }
 
+        @Query()
+        @DescriptorDecorator()
+        queryWithCustomDescriptorDecorator(): boolean {
+          return true;
+        }
+
         @Mutation()
         mutationWithArgs(@Args() args: SampleArgs): number {
           if (args.isTrue()) {
@@ -1507,6 +1527,19 @@ describe("Resolvers", () => {
       expect(queryRoot).toEqual(2);
       expect(queryContext).toEqual("present");
     });
+
+    it("should allow for overwriting descriptor value in custom decorator", async () => {
+      const query = /* graphql */ `
+        query {
+          queryWithCustomDescriptorDecorator
+        }
+      `;
+
+      const { data } = await graphql(schema, query);
+
+      expect(descriptorEvaluated).toBe(true);
+      expect(data.queryWithCustomDescriptorDecorator).toBe(true);
+    });
   });
 
   describe("buildSchema", async () => {