This repository has been archived by the owner on Oct 31, 2019. It is now read-only.
Use indexPathForItemAtPoint: for long press.
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`handleLongPressGesture:` was using `indexPathForItemClosestToPoint:` method to retrieve the index path of the pressed cell. This works well on layouts that fill the entire collection view space but not on other layouts: in the latter case, the closest cell will be selected whereas this is the one under the finger we want to be selected. It now uses `indexPathForItemAtPoint:` instead of `indexPathForItemClosestToPoint:` to get the touched cell.
dredenba
pushed a commit
to dredenba/DraggableCollectionView
that referenced
this pull request
Apr 22, 2016
lukescott#54 originally implemented in: pbernery@4c95c4b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleLongPressGesture:was usingindexPathForItemClosestToPoint:method toretrieve the index path of the pressed cell. This works well on layouts
that fill the entire collection view space but not on other layouts: in the
latter case, the closest cell will be selected whereas this is the one under the
finger we want to be selected.
It now uses
indexPathForItemAtPoint:instead ofindexPathForItemClosestToPoint:to get the touched cell.An by the way, your lib is awesome: I added dragging in a complex layout in a couple of hours.