Fix issue in getType function that will raise an "undefined index" …

…notice when there's no file. Fix bug in PodcastPage (missing $this->).
lukereative · Oct 8, 2015 · 05ceb72 · 05ceb72
1 parent 02fb158
commit 05ceb72
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/code/dataobjects/PodcastEpisode.php b/code/dataobjects/PodcastEpisode.php
@@ -128,8 +128,10 @@ public function getMime() {
 	* @return string
 	*/
 	public function getType() {
-		$filename = $this->EpisodeFile()->getFilename();
-		$filename = explode('.', $filename);
+		// return an empty string if there's no file
+		if(!$this->EpisodeFileID){
+			return '';
+		}
 
 		$mime_types = array(
 			'mp3' => 'audio'
@@ -145,7 +147,7 @@ public function getType() {
 			,'3gp' => 'video'
 		);
 
-		$extension = strtolower(end($filename));
+		$extension = strtolower($this->EpisodeFile()->getExtension());
 
 		return $mime_types[$extension];
 	}

diff --git a/code/pagetypes/PodcastPage.php b/code/pagetypes/PodcastPage.php
@@ -221,7 +221,7 @@ public function podcastEpisodes() {
 	 */
 	public function paginatedPodcastEpisodes() {
 		$paginatedList = new PaginatedList(
-			podcastEpisodes()
+			$this->podcastEpisodes()
 				->filter(array('BlockEpisode' => '0'))
 				->sort('EpisodeDate', 'DESC')
 				, $this->request