Marshmallow Based Event Schema Validation

[piotrekno1]

Coversation of the discussion started in: #21

I know that for now this looks super ugly but wanted to get your feedback on:

• Placement of the validation code. Validation is controlled by Repository class.
• How do you like the Schema registration API? It mimics what is done for mutators.
• Do you like the fact that only event data is validated (static fields of an event are skipped to avoid repetetive work).

Things that needs to be changed if we agree on the points above:

• Decide where to place schema definitions in examples (schema.py ?).
• Add tests
• Relax the setup.py import
• Strict mode to enforce validation (?)

[lukaszb]

I really like it, plain and simple.

• Placement of the validation code. Validation is controlled by Repository class.

👍 This way we'd keep Storage.store raw (so it's good for example in testing). People should use Repository for real usage anyway.

• How do you like the Schema registration API? It mimics what is done for mutators.

Looks cool. I wonder if we can combine two things, though - event definition and mutator. This, however, can be done in a next step.

• Do you like the fact that only event data is validated (static fields of an event are skipped to avoid repetetive work).

Sure, we can extend that in future but I'm not sure if that would be needed at all. Data is all we should care for now.

[piotrekno1]

Please see the proposal.

[lukaszb]

I like it! I have only one request

[lukaszb]

please propagate errors in a raised exception instance

[piotrekno1]

@lukaszb Not sure I understood. Does 1d50e99 address your feedback? If so 100% agree.

[lukaszb]

@piotrekno1 exactly, thanks :)