chore: rewrite extract_latex.py to not use numpy #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get rid of unnecessary dependencies - get the same functionality - faster code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
pix2tex/dataset/extract_latex.pyfile to simplify the code and remove unnecessary dependencies. The most important changes include removing thenumpyimport and refactoring thecheck_bracketsfunction to use built-in Python functions instead ofnumpy.Codebase simplification:
pix2tex/dataset/extract_latex.py: Removed the import of thenumpylibrary as it was not necessary for the operations being performed.pix2tex/dataset/extract_latex.py: Refactored thecheck_bracketsfunction to use the built-insumfunction instead ofnumpy.cumsum, simplifying the code and removing the dependency onnumpy.