-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edge.py #112
base: main
Are you sure you want to change the base?
Update edge.py #112
Conversation
added edge detector based on Sujoy's algorithm
Sorry for the delay, but this fails on travis (also, locally): https://travis-ci.com/github/luispedro/mahotas/builds/170839189 |
Also, this PR and #111 should be merged into one or does this one completely subsume the previous one? |
But what's the error Luis? I am not getting/clear... Please help. |
These are the test cases |
The test cases should be with the code together in the same PR But, in any case, the code does not even pass a smoke test: it mixes tabs & spaces. |
I will correct the space/tab errors & resubmit. But I am not sure how to put both (test case + function) together in one PR. Can you please help Luis? |
You can update PRs by adding commits to their respective branches. It does not need to be a single commit per PR. |
corrected space/tab errors... all indentation are now tabs...
update threshold 't'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is final commit for function 'sujoy()'. Please accept changes.
test_edge.py updated with sujoy-edge-detector test cases
Patch 2 updated with test cases
updated test cases with parameter "kernel_nhood=1"
line 103 from"mh.sujoy" to "sujoy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is final commit for function 'test cases'. Please accept changes.
Hi Luis, "build" is complete on Travis. Added few more test-cases also. sorry for so many "commits"; as I am new to GITHUB. Thanks. |
update test_3d_error1() function
Is there anything wrong, that you are not merging, Luis? |
Is this approach being used? I only saw your manuscript, but I did not find some citations and/or comments from users. |
I don't know who are using this. However this has got accepted in Julia Image Library (https://juliaimages.org/stable/examples/contours/sujoy_edge_demo/#Edge-detection-using-Sujoy-Filter) & also in the process of inclusion in a Java Image Library. Soon I shall copyright this. Thanks. |
added edge detector based on Sujoy's algorithm