Add database schema

[WizzyGeek]

Adds normalised database models.

[parrothacker1]

Bhaiyya do we need a team id field in the team model ? Cuz we are using name as the primary key in the team model.Should I make a new commit for that ?

[WizzyGeek]

@Meetesh-Saini
@mradigen
@parrothacker1

I am trying to achieve a 2NF database schema
Can you check if these models cover all our database requirements? (except the User and Team models, I do not know the requirements for that @parrothacker1 do let me know)

[Meetesh-Saini]

Problem doesn't have any primary key. Add problem id for it. Also we can merge Image to Problem

[mradigen]

Problem doesn't have any primary key. Add problem id for it. Also we can merge Image to Problem

Tortoise adds an ID of its own if no primary key is mentioned

[WizzyGeek]

All of the Models without a primary key rely on the default from the ORM

And I liked to remain high level and let the orm manage the exact details of relations

[WizzyGeek]

About the team having a max of N users

I tried two approaches

DO $$ 
BEGIN 
    IF NOT EXISTS (
        SELECT 1 
        FROM pg_constraint 
        WHERE conname = 'max_users_per_team_constraint' 
    ) THEN
        -- Add the constraint only if it doesn't exist
        ALTER TABLE "user" 
        ADD CONSTRAINT max_users_per_team_constraint 
        CHECK ((SELECT COUNT(*) FROM "user" WHERE team_id = "user".team_id) <= 3);
    END IF;
END $$;

but that lead to

asyncpg.exceptions.FeatureNotSupportedError: cannot use subquery in check constraint

So I setup a trigger on the DB

CREATE OR REPLACE FUNCTION check_max_users_per_team()
RETURNS TRIGGER AS $$
BEGIN
    IF (
        SELECT COUNT(*) 
        FROM "user" 
        WHERE team_id = NEW.team_id
    ) >= 3 THEN
        RAISE EXCEPTION 'Cannot have more than 3 users in a team';
    END IF;
    RETURN NEW;
END;
$$ LANGUAGE plpgsql;

DROP TRIGGER IF EXISTS max_users_per_team_trigger ON "user";

CREATE TRIGGER max_users_per_team_trigger
BEFORE INSERT OR UPDATE ON "user"
FOR EACH ROW EXECUTE FUNCTION check_max_users_per_team();

[WizzyGeek]

I wrote 3 over there but I will just inject the actual value

[WizzyGeek]

Now trying to create more than 3 Users for one team leads to an Error from the driver

await User.create(user_name="345", team_id=2)

Edit (after new commits):

await User.create(name="345", team_id=2)

asyncpg.exceptions.RaiseError: Cannot have more than 3 users in a team

[WizzyGeek]

Now the question is,

• Use trigger or
• Use application side validation

[WizzyGeek]

All has been tested, now only missing annotation for image_config and constraint checking based on config value

[mradigen]

All has been tested, now only missing annotation for image_config and constraint checking based on config value

Currently the image_config is the raw POST data that is sent to the Docker Remote API. For now it only contains the ports required to be opened on the host, but I've left it as JSON for flexibility in case a CTF requires custom network configs.