-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented coreml exporter #3813
Conversation
for more information, see https://pre-commit.ci
Unit Test Results 6 files ±0 6 suites ±0 13m 49s ⏱️ -34s Results for commit b769b22. ± Comparison against base commit 5cf9110. This pull request skips 2 tests.
|
from ludwig.model_export.base_model_exporter import BaseModelExporter, LudwigTorchWrapper | ||
|
||
|
||
class CoreMLExporter(BaseModelExporter): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saad-palapa I cannot find any problems; I would only like to request -- if you do not mind -- to please add type hints, at least to the non-obvious variables and all return values of methods (for me, personally, I prefer them everywhere). Also, could someone else -- @arnavgarg1, @geoffreyangus, @justinxzhao please review? Thank you.
@@ -0,0 +1,53 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add from __future__ import annotations
at the very top followed by a blank line.
This will help modernize type hints (and make them easier to add -- without cyclical conflicts). Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saad-palapa I request one change and made one suggestion. Thank you so much for this addition!
We will close older PRs. Especially if they do not contain a clear explanation for their necessity. |
Code Pull Requests
Please provide the following:
TODO(saad)
Documentation Pull Requests
Note that the documentation HTML files are in
docs/
while the Markdown sources are inmkdocs/docs
.If you are proposing a modification to the documentation you should change only the Markdown files.
api.md
is automatically generated from the docstrings in the code, so if you want to change something in that file, first modifyludwig/api.py
docstring, then runmkdocs/code_docs_autogen.py
, which will createmkdocs/docs/api.md
.