Compute the SemanticDB target root correctly #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Bazel, `File#short_path` is prefixed with `..` if the file belongs to an external repository. However, this isn't meant to be interpreted as a relative path, as external repositories' outputs are in the `external` output directory. This meant that when `semanticdb_bundle` was enabled and external repositories contained Scala rules, they'd fail to build, since the `-P:semanticdb:sourceroot` or `-semanticdb-target` compiler options would be computed incorrectly.
|
By the way, I verified this works with path mapping. |
jjudd
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bazel,
File#short_pathis prefixed with..if the file belongs to an external repository. However, this isn't meant to be interpreted as a relative path, as external repositories' outputs are in theexternaloutput directory.This meant that when
semanticdb_bundlewas enabled and external repositories contained Scala rules, they'd fail to build, since the-P:semanticdb:sourcerootor-semanticdb-targetcompiler options would be computed incorrectly.