Do dependency checking via a validation action #62
Conversation
|
Have you tested that |
|
For when we pull this into our main repo you will want to experiment with |
jadenPete
force-pushed
the
make-dependency-checking-a-validation-action
branch
from
16a61d6 to
99835eb
Compare
Good idea. I just tried building |
Will do. |
jadenPete
force-pushed
the
make-dependency-checking-a-validation-action
branch
from
99835eb to
3b92fcc
Compare
| if deps_configuration.used == "error": | ||
| outputs.append(deps_checks["used"]) | ||
| if getattr(deps_configuration, name) == "error": | ||
| outputs.append(deps_check) |
There was a problem hiding this comment.
If you removed deps_check from line 24, then where is deps_check coming from?
There was a problem hiding this comment.
It should be coming from line 28.
Previously, it was generated in the "javainfo" phase, which runs before the "depscheck" phase. "javainfo" can't run after "depscheck" because "compile" depends on "javainfo", and "depscheck" can't run before "javainfo" because it depends on "compile".
This shouldn't be necessary, now that we're using validation actions.
jjudd
force-pushed
the
make-dependency-checking-a-validation-action
branch
from
78d0667 to
18aa2de
Compare
…ing the worker response There was a race condition where a task could be cancelled with the worker output streams still set to null, which would cause a null pointer exception in the worker. We also weren't always flushing the print stream before responding to Bazel about the work request. This fixes that.
jjudd
force-pushed
the
make-dependency-checking-a-validation-action
branch
from
18aa2de to
ac07080
Compare
You can read more about validation actions here:
https://bazel.build/extending/rules#validation_actions
This should enable dependency checking to be performed concurrently with
phase_singlejar.