forked from higherkindness/rules_scala
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path mapping #59
Closed
Closed
Path mapping #59
+430
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjudd
changed the title
[WIP] Path mapping (stack on the toolchains PR)
[WIP] Path mapping (stacked on the toolchains PR)
Oct 17, 2024
jadenPete
force-pushed
the
implement-a-toolchain
branch
4 times, most recently
from
November 14, 2024 16:14
1fd0fb1
to
80af0ac
Compare
…apping Path mapping requires a custom Java toolchain where javac_supports_worker_multiplex_sandboxing is set to True. There was an issue where rules_jvm_external came before rules_java in the WORKSPACE and it called the default rules_java toolchain setup functions, preventing our custom toolchain from being used correctly. This in turn broke path mapping.
…ferent configurations Currently we compare the absolute path in the deps checker. This causes us problems when there are configuration specific parts of one input and not the other. This happens when there we've written a configuration specific part of a path to disk and are comparing it to a path mapped argument. I imagine this is not the only place we'll run into issues with this.
jjudd
force-pushed
the
path-mapping-stacked-toolchain
branch
3 times, most recently
from
November 15, 2024 07:23
2abc7d0
to
fc1fd79
Compare
We replace the string ${workDir} with the workDir path. Problem is, sometimes the workDir path is " " (the current directory). If that's the case, then we replace ${workDir} with a blank string. Using an absolute path prevents that blank string from happening.
Because we're using strings, names like zinc_3 would likely conflict in other repos.
For some reason multiplex sandboxing seems to have issues with files going missing. It's been happening for a while, but intermittently. It got much worse recently. Not sure if this is a rule set bug or a Bazel bug. Regardless, disabling multiplex sandboxing fixes it.
jjudd
force-pushed
the
path-mapping-stacked-toolchain
branch
from
November 15, 2024 07:52
fc1fd79
to
c33607b
Compare
Loading status checks…
…authors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for path mapping and improves a variety of other small things.