Sends verbosity from the worker protocol to the worker and enable Java toolchain multiplex sandboxing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules_java supports it, and we support it, so we might as well use it.
None of the workers use it yet, but it is an update to the interface. Want to get it merged, so we can stop making changes to the interface for a bit.
jadenPete
approved these changes
Sep 9, 2024
| @@ -14,7 +14,7 @@ abstract class WorkerMain[S](stdin: InputStream = System.in, stdout: PrintStream | |||
|
|
|||
| protected[this] def init(args: Option[Array[String]]): S | |||
|
|
|||
| protected[this] def work(ctx: S, args: Array[String], out: PrintStream, workDir: Path): Unit | |||
| protected[this] def work(ctx: S, args: Array[String], out: PrintStream, workDir: Path, verbosity: Int): Unit | |||
There was a problem hiding this comment.
Since we're getting the arguments and verbosity directly from the work request, should we just pass that to the worker directly instead of copying so many of its fields?
There was a problem hiding this comment.
I'm not sure we should because this does create a nice interface all the workers must adhere to. It does sometimes mean updates when the protocol changes. Good news is that tends to happen rather infrequently.
There was a problem hiding this comment.
Yeah, I can see how this forces worker implementers to think about certain things. Nevermind, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.