Handle jvm external stamping and canonical repo names #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2024 12:58
If you were using rules_jvm_external's stamping for the jars you create an AnnexScalaInstance with, then the jars would be filtered out of a collection they shouldn't have been and you'd get a null error when looking for the compiler version.
…op disabling bzlmod We don't actively use bzlmod yet, but we're no longer disabling it.
JaredNeil
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug caused when using rule_jvm_external's jar stamping for the jars you create an AnnexScalaInstance with.
Fixes a bug that happens when canonical repository names get used for labels when bzlmod is enabled
Stops disabling bzlmod
Stops loading the rules_java toolchains as we supply our own