JDK 21 support, consistent Zinc analysis format, Zinc classloader improvements, lots of upgrades #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
June 19, 2024 18:56
They did not add the remotejdk_21 target from bazel_tools and instead are recommending people use rules_java instead.
The JDK deprecated the SecurityManager: https://openjdk.org/jeps/411 In JDK 18+ accessing the SecurityManager throws an UnsupportedOperationException. There is no alternative way to trap JVM exits and prevent them. There is a ticket for the JDK to add a way to do this https://bugs.openjdk.org/browse/JDK-8199704 sbt ran into this same issue and resovled it just by not trapping exits anymore sbt/sbt#6665 sbt/sbt#6558
The ClassLoaders were mostly correct, but this should get things the rest of the way to being correct. Or at least similarly correct to Zinc and Bloop.
Bring back our read write mappers, so things are machine independent and timestamps don't cause problems.
…ility problems Consistent text format deserialization has a problem, so that's why I'm adding the additional output for now. Will remove it once I've figured out what is going on.
added 2 commits
July 6, 2024 17:35
annex_3 is unnecessary and using it can cause multiple Scala 2 library jars to end up on the classpath
…roblems It's not totally certain whether the determinism issues come from the intersection of our AnnexScalaInstance + the CloassLoaderCache or from the ClassLoaderCache cache itself.
jjudd
force-pushed
the
jdk-21-support
branch
2 times, most recently
from
641d29a to
543fdbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.