Update all the things and fix/finish the worker implementation #25
Conversation
rules_scala_annex supports it and we now support it, so we might as well use it.
| arg[File]("<outputDirectory>").required().action { (value, config) => | ||
| config.copy(generatedDirectory = value) | ||
| arg[Path]("<outputDirectory>").required().action { (outputDirectory, config) => | ||
| config.outputDirectory = SandboxUtil.getSandboxPath(workDir, outputDirectory) |
There was a problem hiding this comment.
Nit: I'm not a huge fan of the mutability here. What's wrong with .copy? If we're trying to micro-optimize, are the benefits really worth it?
There was a problem hiding this comment.
Speed is the reason. I do think it's worth it because that many object copies is not very fast.
Also I'm not too worried about it as the only uses of this object are in this file, it's very short, and reasoning about correctness is much easier than a larger codebase.
There was a problem hiding this comment.
I'm assuming this and JarHelper.java were copied verbatem from Bazel, so I'm not going to fully review them. That being said, is there any way we can depend on these (e.g. by pulling in Bazel's code as a sub-repository) instead of copying them?
There was a problem hiding this comment.
Good question. I haven't been able to figure out how to depend on this, so whenever I've needed it I just copy it.
No description provided.