play 3.0.3 #23
Merged
play 3.0.3 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,6 +92,7 @@ object CommandLinePlayRoutesCompiler { | |||
| config.additionalImports, | |||
| config.generateForwardsRouter, | |||
| config.generateReverseRouter, | |||
| config.jsReverseRouter, | |||
There was a problem hiding this comment.
We use the javascript reverse routes quite a bit so we'll either want to just use generateReverseRouter for this rather than adding a new field, or make this configurable based on the command line options and add it to the bazel rules here. Adding a command line option and an input to the bazel rule would be best, but a lot more work, so I think it's fine if you just want to use config.generateReverseRouter here and not bother with the other changes
coreywoodfield
requested changes
May 31, 2024
coreywoodfield
approved these changes
Jun 3, 2024
SrodriguezO
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade Play to 3.0.3