Added --output_folder, updated params, and tidied documentation #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tables to tighten up documentation to reduce scrolling, cuts down on the amount of empty space between samples. Updated CLI with the latest instructions from running imagine --help and included the currently available models and optimizers. Removed screenshots from the Windows section and provided samples from running it on my workstation to simplify instructions for newer users. Added steps to verify CUDA devices are available to torch prior to running. Tested on Windows 10 / Python 3.9 / RTX 2070 and AWS Deep Learning AMI Ubuntu 18.04 / Python 3.6 / Tesla T4
This will create the directory structure recursively and return a POSIX compatible Path() from Pathlib. Tested on Windows 10 and Ubuntu.
output_folder needs to be explicitly typed otherwise a passed integer will cause it to fail. Probably has to do with the use of sys.argv and could be set in cli.py or switch over to argparse, but that is up to lucidrains if that route is taken.
|
It looks like |
Fixed the out of alignment table in the intro. Changed a few sentences to be less wordy.
|
Oh man, this is so useful to me. Thank you! |
|
The |
gandie
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been tinkering with this and made the following changes
--output_folderto the command line arguments, which will create the path recursively and return a POSIX path for output.I really dig this project although depending on what you feed it the results are nightmare fuel.