Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): rename box-select to square-dashed #2506

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

chessurisme
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

The icon named box-select violates the naming convention as outlined in Naming convention in Lucide's design principle #3. Instead of using box-select, we will rename it to square-dashed, following the convention used in names like square-dashed-mouse-pointer.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

Added or changed icons

icons/square-dashed.svg

Preview cohesion icons/square-activity.svg
icons/square-dashed.svg
icons/badge-percent.svg
Preview stroke widths icons/square-dashed.svg
icons/square-dashed.svg
icons/square-dashed.svg
DPI Preview (24px) icons/square-dashed.svg
Icon X-rays icons/square-dashed.svg
Icon Diffs icons/square-dashed.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SquareDashedIcon = createLucideIcon('SquareDashed', [
  ["path",{"d":"M5 3a2 2 0 0 0-2 2"}],
  ["path",{"d":"M19 3a2 2 0 0 1 2 2"}],
  ["path",{"d":"M21 19a2 2 0 0 1-2 2"}],
  ["path",{"d":"M5 21a2 2 0 0 1-2-2"}],
  ["path",{"d":"M9 3h1"}],
  ["path",{"d":"M9 21h1"}],
  ["path",{"d":"M14 3h1"}],
  ["path",{"d":"M14 21h1"}],
  ["path",{"d":"M3 9v1"}],
  ["path",{"d":"M21 9v1"}],
  ["path",{"d":"M3 14v1"}],
  ["path",{"d":"M21 14v1"}]
])

Copy link

Added or changed icons

icons/square-dashed.svg

Preview cohesion icons/message-square-dot.svg
icons/square-dashed.svg
icons/store.svg
Preview stroke widths icons/square-dashed.svg
icons/square-dashed.svg
icons/square-dashed.svg
DPI Preview (24px) icons/square-dashed.svg
Icon X-rays icons/square-dashed.svg
Icon Diffs icons/square-dashed.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SquareDashedIcon = createLucideIcon('SquareDashed', [
  ["path",{"d":"M5 3a2 2 0 0 0-2 2"}],
  ["path",{"d":"M19 3a2 2 0 0 1 2 2"}],
  ["path",{"d":"M21 19a2 2 0 0 1-2 2"}],
  ["path",{"d":"M5 21a2 2 0 0 1-2-2"}],
  ["path",{"d":"M9 3h1"}],
  ["path",{"d":"M9 21h1"}],
  ["path",{"d":"M14 3h1"}],
  ["path",{"d":"M14 21h1"}],
  ["path",{"d":"M3 9v1"}],
  ["path",{"d":"M21 9v1"}],
  ["path",{"d":"M3 14v1"}],
  ["path",{"d":"M21 14v1"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the alias field for backwards compatibility.

@chessurisme
Copy link
Contributor Author

How do I? I haven't read any ‘alias’ or same thing in the documentation. Would you point out similar icons that renamed like box-select? Thanks.

@jguddas
Copy link
Member

jguddas commented Sep 30, 2024

How do I? I haven't read any ‘alias’ or same thing in the documentation. Would you point out similar icons that renamed like box-select? Thanks.

You can search the code it's in the .json, I'm on the phone right now, that's the best I can do.

You can also check the icon schema.

@chessurisme
Copy link
Contributor Author

I already added an aliases.

@karsa-mistmere karsa-mistmere merged commit 542507f into lucide-icons:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants