Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the sustainability category to some existing icons #2384

Conversation

VIKTORVAV99
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds the sustainability category to some of the existing icons that are related to sustainability for easier discovery.

Before Submitting

@VIKTORVAV99
Copy link
Contributor Author

@jguddas would it also be okay to add an entirely new category called Energy for well all energy related things?

Plugs, Zap, Wind, Solar, Pole, Waves, Flame, Drop and more would all fit in this category.

@karsa-mistmere karsa-mistmere merged commit 79c2333 into lucide-icons:main Aug 21, 2024
5 of 6 checks passed
@karsa-mistmere
Copy link
Member

Nice work, @VIKTORVAV99

@jguddas would it also be okay to add an entirely new category called Energy for well all energy related things?

Plugs, Zap, Wind, Solar, Pole, Waves, Flame, Drop and more would all fit in this category.

I think this would duplicate most of sustainability, would it not? I think every icon in energy would also appear in sustainability for sure.

@VIKTORVAV99
Copy link
Contributor Author

Nice work, @VIKTORVAV99

@jguddas would it also be okay to add an entirely new category called Energy for well all energy related things?
Plugs, Zap, Wind, Solar, Pole, Waves, Flame, Drop and more would all fit in this category.

I think this would duplicate most of sustainability, would it not? I think every icon in energy would also appear in sustainability for sure.

It's true that it would be a lot of overlap between the two, at least for now but things like Flame for example would not be in the sustainable category.

It would also serve to match the FontAwesome energy category and help with discovery. In Electricity Maps we have also discussed adding icons that represent coal, gas and oil for example that would all be energy related icons but not sustainable.

But if you rather not create a new category for it I'll just update all the tags instead but it's not as easy to discover vs using categories.

realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants