chore(icons): update icon names to match naming guidelines no. 7 to 9 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update and extend rename icon helper script.
…helper script usages to crash.
Added or changed iconsPreview cohesion                                                                                                              |
added 9 commits
February 22, 2024 09:49
added 4 commits
February 22, 2024 11:48
pnpm rename contact-2 contact-round
rename mic-2 mic-vocal rename loader-2 loader-circle rename test-tube-2 test-tube-diagonal rename school-2 university
rename ice-cream-2 => ice-cream-bowl rename laptop-2 => laptop-abstract
ericfennis
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Excellent work @karsa-mistmere !
I've some suggestions for some renaming
icons/wallet-abstract.json
Outdated
There was a problem hiding this comment.
Same as laptop-abstract, not sure about the abstract word. What about square-wallet?
There was a problem hiding this comment.
It's not in a square though, is it? 🙃
wallet-square would also be weird, since the other wallet icon is also rectangular.
There was a problem hiding this comment.
You right, maybe also with the minimal word, wallet-minimal?
There was a problem hiding this comment.
Done, I simply ran the command below. :)
pnpm renamePattern '^(.+)-abstract$' '\1-minimal' --add-alias=false
3 tasks
jguddas
changed the title
jguddas
changed the title
jguddas
changed the title
…false feat(scripts): added yargs option parsing to renamePattern
…hey are no longer in use but cause pnpm install to fail
github-actions
bot
added
📦 dependencies
added 4 commits
February 28, 2024 18:43
chore(icons): renamePattern '^(square|circle)-check-small$' '\1-check'
ericfennis
approved these changes
Mar 8, 2024
# Conflicts: # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Our naming guidelines were updated in #1874, but a lot of icons don't yet match the new official naming scheme, this PR updates most (if not all) of these icons, while also adding backward compatible aliases.
A
renamePatternhelper script was also created that helps streamline these batched renames, e.g. most of the hard work was done via running:Before Submitting