Linting SVG files #1642
Merged
Linting SVG files #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 dependencies
Added or changed icons
Preview cohesion   Preview stroke widths  DPI Preview (24px) Icon X-rays
|
jguddas
requested changes
Oct 27, 2023
Co-authored-by: Jakob Guddas <[email protected]>
Co-authored-by: Jakob Guddas <[email protected]>
…nto svg-eslint
…nto svg-eslint
|
@jguddas Thanks for your feedback! |
jguddas
reviewed
Nov 1, 2023
| @@ -29,21 +29,22 @@ | |||
| "generate:contributors": "node ./scripts/updateContributors.mjs icons/*.svg", | |||
| "generate:nextJSAliases": "node ./scripts/generateNextJSAliases.mjs", | |||
| "postinstall": "husky install", | |||
| "lint:js": "eslint --ext .ts,.js,.mjs ./{packages/lucide,scripts}", | |||
There was a problem hiding this comment.
Now the :js name does not make sense anymore.
There was a problem hiding this comment.
true, i've renamed it to lint:es 😛
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
When running Eslint running from the root, it reads also TS files, which requires a tsconfig in the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
This adds a feature to lint SVG files. I've implemented the
@html-eslintwith some rules that match our way of writing the SVGs.Because it is part of ESLint, lint-staged will check the format of SVGs.
I also added a GitHub action to check this when a PR is opened. GitHub will automatically add a comment if the formatting is incorrect.