Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added webhook-off icon #1566

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 18, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

To unlink a webhook.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: webhook
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Added or changed icons

icons/webhook-off.svg

Preview cohesion icons/menu-square.svg
icons/webhook-off.svg
icons/badge-help.svg
Preview stroke widths icons/webhook-off.svg
icons/webhook-off.svg
icons/webhook-off.svg
DPI Preview (24px) icons/webhook-off.svg
Icon X-rays icons/webhook-off.svg

@jguddas
Copy link
Member Author

jguddas commented Sep 18, 2023

icons/webhook-off.svg

@karsa-mistmere
Copy link
Member

I feel like removing a webhook would be better represented by something like webhook-x, e.g.
image

But why an extra icon in the first place? Why not just put a simple x, trash or unlink icon next to the webhook in question?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
@github-actions github-actions bot removed the Stale label Jan 5, 2024
@ericfennis
Copy link
Member

@karsa-mistmere I think we also should add webhook-x. To me, it can also have a different meaning. It can also mean that the webhook is "broken" or "unable to reach the webhook".

@ericfennis ericfennis merged commit 28686b5 into lucide-icons:main Jan 25, 2024
7 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants