feat: added dpi preview #1510
Merged
feat: added dpi preview #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 dependencies
jguddas
force-pushed
the
feat/added-dpi-preview
branch
2 times, most recently
from
5b070f4
to
744ef4d
Compare
This reverts commit dcb9fe3.
Co-authored-by: Eric Fennis <[email protected]>
jguddas
force-pushed
the
feat/added-dpi-preview
branch
from
5173507
to
dbb2cf1
Compare
jguddas
commented
Aug 18, 2023
jguddas
commented
Aug 18, 2023
jguddas
commented
Aug 18, 2023
jguddas
commented
Aug 18, 2023
jguddas
commented
Aug 18, 2023
ericfennis
reviewed
Aug 19, 2023
There was a problem hiding this comment.
@jguddas Awesome work, this is really cool!
Question: What's the benefit of adding the 18px preview of the low DPI preview?
I think we should check that our icons work at 75% scale, using 18px high icons is super common. |
jguddas
commented
Aug 20, 2023
jguddas
commented
Aug 20, 2023
|
@jguddas Yeah but all icons are designed on 24px. So 18px will probably always looks blurry. So I'm not sure if this preview is useful. |
jguddas
commented
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a preview with the icon pixelated to see how they look on non-high-dpi screens.
Example: jguddas/github-icon-worflow-test#17 (comment)