Skip to content

Commit

Permalink
Merge branch 'main' into improve-license-packages
Browse files Browse the repository at this point in the history
  • Loading branch information
ericfennis authored Nov 1, 2023
2 parents e102fcb + a1a9a4d commit 9ada747
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
8 changes: 4 additions & 4 deletions packages/lucide/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ const configs = bundles
name: outputFileName,
...(preserveModules
? {
dir: `${outputDir}/${format}`,
}
dir: `${outputDir}/${format}`,
}
: {
file: `${outputDir}/${format}/${outputFileName}${minify ? '.min' : ''}.js`,
}),
file: `${outputDir}/${format}/${outputFileName}${minify ? '.min' : ''}.js`,
}),
format,
sourcemap: true,
preserveModules,
Expand Down
15 changes: 11 additions & 4 deletions packages/lucide/src/lucide.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as iconAndAliases from './iconsAndAliases';
const createIcons = ({ icons = {}, nameAttr = 'data-lucide', attrs = {} } = {}) => {
if (!Object.values(icons).length) {
throw new Error(
"Please provide an icons object.\nIf you want to use all the icons you can import it like:\n `import { createIcons, icons } from 'lucide';\nlucide.createIcons({icons});`",
"Please provide an icons object.\nIf you want to use all the icons you can import it like:\n `import { createIcons, icons } from 'lucide';\nlucide.createIcons({icons});`"
);
}

Expand All @@ -18,16 +18,18 @@ const createIcons = ({ icons = {}, nameAttr = 'data-lucide', attrs = {} } = {})

const elementsToReplace = document.querySelectorAll(`[${nameAttr}]`);
Array.from(elementsToReplace).forEach((element) =>
replaceElement(element, { nameAttr, icons, attrs }),
replaceElement(element, { nameAttr, icons, attrs })
);

/** @todo: remove this block in v1.0 */
if (nameAttr === 'data-lucide') {
const deprecatedElements = document.querySelectorAll('[icon-name]');
if (deprecatedElements.length > 0) {
console.warn('[Lucide] Some icons were found with the now deprecated icon-name attribute. These will still be replaced for backwards compatibility, but will no longer be supported in v1.0 and you should switch to data-lucide');
console.warn(
'[Lucide] Some icons were found with the now deprecated icon-name attribute. These will still be replaced for backwards compatibility, but will no longer be supported in v1.0 and you should switch to data-lucide'
);
Array.from(deprecatedElements).forEach((element) =>
replaceElement(element, { nameAttr: 'icon-name', icons, attrs }),
replaceElement(element, { nameAttr: 'icon-name', icons, attrs })
);
}
}
Expand All @@ -45,3 +47,8 @@ export { default as createElement } from './createElement';
*/
export { iconAndAliases as icons };
export * from './icons';

/*
Types exports.
*/
export * from './types';

0 comments on commit 9ada747

Please sign in to comment.