Skip to content

Commit

Permalink
process feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
ericfennis committed Oct 2, 2023
1 parent 2f97c9c commit 007c3ce
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 15 deletions.
1 change: 1 addition & 0 deletions docs/guide/advanced/accessibility.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Accessibility

<!-- Description how you should use svg icons keeping web accessible -->
<!-- See @JanTrichter comment about some information to write this: https://github.com/lucide-icons/lucide/pull/1521#discussion_r1332141390 -->
2 changes: 1 addition & 1 deletion docs/guide/basics/examples/size-icon-example/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ function App() {
);
}

export default App;
export default App;
2 changes: 1 addition & 1 deletion docs/guide/basics/examples/size-icon-font-example/files.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const files = {
code: App,
},
'styles.css': {
code:styles,
code: styles,
hidden: true
},

Expand Down
4 changes: 1 addition & 3 deletions docs/guide/basics/examples/size-icon-font-example/icon.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,4 @@
display: flex;
gap: 0.25em;
items-align: center;
}


}
4 changes: 1 addition & 3 deletions docs/guide/basics/examples/size-icon-tailwind-example/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { PartyPopper } from "lucide-react";
function App() {
return (
<div>
<PartyPopper
className="w-24 h-24"
/>
<PartyPopper className="w-24 h-24" />
</div>
);
}
Expand Down
4 changes: 1 addition & 3 deletions docs/guide/basics/examples/stroke-width-icon/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { FolderLock } from "lucide-react";
function App() {
return (
<div className="app">
<FolderLock
strokeWidth={1}
/>
<FolderLock strokeWidth={1} />
</div>
);
}
Expand Down
4 changes: 2 additions & 2 deletions docs/guide/basics/sizing.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import sizeIconTailwind from './examples/size-icon-tailwind-example/files.ts'

# Sizing

By default, the size of all icons is `24px` times `24px`. The size is adjustable using the `size` prop and CSS.
By default, the size of all icons is `24px` by `24px`. The size is adjustable using the `size` prop and CSS.

## Adjusting the icon size using the `size` prop

Expand Down Expand Up @@ -48,7 +48,7 @@ The CSS properties `width` and `height` can be used to adjust the icon size.

### Dynamically change the icon size based on the font size

It is possible to resize icons based on font size. This can be accomplished by using the `em`s to resize based on font size. See this [MDN article](https://developer.mozilla.org/en-US/docs/Web/CSS/font-size#ems) about ems.
It is possible to resize icons based on font size. This can be achieved using the `em` unit. See this [MDN article](https://developer.mozilla.org/en-US/docs/Web/CSS/font-size#ems) for more information on the `em` unit.

<Sandpack
template="react"
Expand Down
4 changes: 2 additions & 2 deletions docs/guide/basics/stroke-width.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import absoluteStrokeWidth from './examples/absolute-stroke-width-icon/files.ts'
# Stroke width

All icons are designed with SVG elements using strokes.
These have a default of `2px` stroke width.
These have a default stroke width of `2px`.

The `strokeWidth` can be adjusted to create a different look of the icons.

Expand All @@ -32,7 +32,7 @@ The `strokeWidth` can be adjusted to create a different look of the icons.

## Absolute stroke width

When adjusting the `size` prop the size of the stroke width will be relative to the size of the icon, this is the default SVG behavior. The `absoluteStrokeWidth` prop is introduced to adjust this behavior to make the stroke width constant no matter the size of the icon.
When adjusting the `size` prop the size of the stroke width will be relative to the size of the icon, this is the default SVG behavior. The `absoluteStrokeWidth` prop is introduced to adjust this behavior to make the stroke width constant no matter the size of the icon.

This means that when `absoluteStrokeWidth` is enabled and the `size` of the icons is set to `48px` the `strokeWidth` will still be `2px` on the screen.

Expand Down

0 comments on commit 007c3ce

Please sign in to comment.