Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom s3 host handling LDEV-3594 #12

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

fix custom s3 host handling LDEV-3594 #12

wants to merge 24 commits into from

Commits on Jul 19, 2021

  1. fix custom host logic check LDEV-3594

    @zspitzer
    zspitzer authored Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f4ab98f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. improve s3 resource url parsing for custom host urls 

    this includes initial support for parsing s3://miniadmin:minioadmin@http://localhost:9000/bucket

which requires setting for jetS3t
- s3service.https-only = false
"s3service.s3-endpoint-http-port = 9000

Lucee 6 has support for setting env vars for testing this

https://github.com/lucee/Lucee/blob/6.0/test/_setupTestServices.cfc#L118
lucee/Lucee@aae583a
    @zspitzer
    zspitzer committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f6ff404 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Merge branch 'master' into custom-host-fix

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d785f73 View commit details
    Browse the repository at this point in the history

  2. add s3_google profile to GHA

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a5e88af View commit details
    Browse the repository at this point in the history

  3. add S3_GOOGLE_HOST to GHA

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    cabf7da View commit details
    Browse the repository at this point in the history

  4. limit s3 GHA to run synchronously

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    5153f05 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into custom-host-fix

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    366a99a View commit details
    Browse the repository at this point in the history

  6. fix custom s3 host url parsing

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d4da0d1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into custom-host-fix

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    fe20f04 View commit details
    Browse the repository at this point in the history

  8. fix NPE

    @zspitzer
    zspitzer committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    ff9737d View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Merge branch 'master' into custom-host-fix

    @zspitzer
    zspitzer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0a12d05 View commit details
    Browse the repository at this point in the history

  2. avoid NPE

    @zspitzer
    zspitzer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7532022 View commit details
    Browse the repository at this point in the history

  3. support s3 commonPrefixes LDEV-3631

    @zspitzer
    zspitzer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    911af22 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. fix parsing s3://buckname urls without host

    @zspitzer
    zspitzer committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c11cb5b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. improve host parsing

    @zspitzer
    zspitzer committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    540c8df View commit details
    Browse the repository at this point in the history

  2. always check common prefixes

    @zspitzer
    zspitzer committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    7b1c93d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. ensure a s3 host is always prefixed with an @

    @zspitzer
    zspitzer committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    aaafad2 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. don't add host to url when not using custom creds

    @zspitzer
    zspitzer committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    4273c70 View commit details
    Browse the repository at this point in the history

  2. try using listObjectsChunked instead of listObjects

    @zspitzer
    zspitzer committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    c3eedb4 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. target java 1.8

    @zspitzer
    zspitzer committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    3468aaf View commit details
    Browse the repository at this point in the history

  2. fix delete check when force is false

    @zspitzer
    zspitzer committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    e855729 View commit details
    Browse the repository at this point in the history

  3. fix merge conflict, remove whitespace

    @zspitzer
    zspitzer committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    b25830f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into custom-host-fix

    @zspitzer
    zspitzer authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8da9d0d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. more null checks and logout host on error

    @zspitzer
    zspitzer committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e8c6c62 View commit details
    Browse the repository at this point in the history