improve test cases

lucee · Jul 13, 2024 · 2d931f5 · 2d931f5
1 parent f4bb3b2
commit 2d931f5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/tests/functions/S3Download.cfc b/tests/functions/S3Download.cfc
@@ -32,7 +32,6 @@ Sorglos";
  it(title="download as binary", body = function( currentSpec ) {
  var cred=currentSpec.cred;
  var bucketName=currentSpec.bucketName;
- createBucket(cred,bucketName);
  var data=s3Download(bucket:bucketName,object:objectName,accessKeyId:cred.ACCESS_KEY_ID,secretAccessKey:cred.SECRET_KEY);
  assertTrue(isBinary(data));
  assertEquals(len(data),12);

diff --git a/tests/general/BigBucket.cfc b/tests/general/BigBucket.cfc
@@ -34,7 +34,7 @@ component extends="org.lucee.cfml.test.LuceeTestCase" labels="s3" {
  accessKeyId:cred.ACCESS_KEY_ID, secretAccessKey:cred.SECRET_KEY, host:(isNull(cred.HOST)?nullvalue():cred.HOST));
  }
  }
- arguments.spec.body({bucketName:bucketName,cred:cred});
+ arguments.spec.body({bucketName:bucketName,cred:cred,records:records});
  } 
  finally {
  Util::deleteBucketEL(cred,bucketName);
@@ -46,6 +46,7 @@ component extends="org.lucee.cfml.test.LuceeTestCase" labels="s3" {
  it(title="checking with S3ListBucket", skip=Util::isAWSNotSupported(), body = function( currentSpec ) {
  var cred=currentSpec.cred;
  var bucketName=currentSpec.bucketName;
+ var records=currentSpec.records;
  var cred=Util::getAWSCredentials()
 
  if(records==0){

diff --git a/tests/general/Region.cfc b/tests/general/Region.cfc
@@ -36,8 +36,7 @@ component extends="org.lucee.cfml.test.LuceeTestCase" labels="s3" {
  ,secretAccessKey:cred.SECRET_KEY
  );
 
- // if it has a dot it should not start with http://bundle.download.s3.amazonaws.com
- assertEquals("http://s3.amazonaws.com/bundle.download", res);
+
  });
  });
  }