Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support synchronous put operation #15

Closed
wants to merge 3 commits into from

Conversation

davidAtInleague
Copy link

To fix #13, this enables a "synchronous" mode for the put operation. A configuration can now look like:

this.cache.connections[ "x" ] = {
	class : 'lucee.extension.io.cache.redis.simple.RedisCache',
	bundleName : 'redis.extension',
	bundleVersion : '3.0.0.<x>',
	storage : true,
	custom : {
		"password" : "",
		"port" : "1234",
		...
		"synchronousPut": true,
	}
};

Very high confidence this fixes the reported race condition, but I haven't done any performance regression testing to see how this pans out in the real world. However, the new option is entirely opt-in, so any regressions would be new behavior that people have to sign up for via configuration.

requires that cf code pass a `{...,synchronous:true}` param in
its config to the plugin
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2023

CLA assistant check
All committers have signed the CLA.

@davidAtInleague
Copy link
Author

closed in favor of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache pulls non-deterministically return a live object ref to some "other" object
2 participants