Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #720 #723

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix issue #720 #723

merged 2 commits into from
May 18, 2024

Conversation

lucatume
Copy link
Owner

@lucatume lucatume commented May 18, 2024 •
edited
Loading

Update the Core PHPUnit suite patch to avoid calling wpdb::db_connect twice.
The first time when the wp-settings.php file is loaded as part of the WPLoader bootstrap phase, the second time during WPTestCase::setUpBeforeClass.

Fixes #720

@lucatume lucatume self-assigned this May 18, 2024
@lucatume lucatume marked this pull request as ready for review May 18, 2024 14:23
@lucatume lucatume merged commit 628c780 into master May 18, 2024
43 checks passed
@lucatume lucatume deleted the fix-issue-720 branch May 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lucatume lucatume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] race conditions & bugs due to connecting twice to database with WPTestCase and WPLoader | v3
1 participant
@lucatume