Skip to content

Commit

Permalink
remove libphonenumber-compose module. use androidx-startup-runtime
Browse files Browse the repository at this point in the history
androidx-startup-runtime supplies application context
  • Loading branch information
luca992 committed Nov 1, 2023
1 parent 636cfe1 commit 95ded84
Show file tree
Hide file tree
Showing 17 changed files with 47 additions and 183 deletions.
123 changes: 0 additions & 123 deletions libphonenumber-compose/build.gradle.kts

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions libphonenumber-compose/src/commonMain/kotlin/PhoneNumberUtil.kt

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 3 additions & 0 deletions libphonenumber/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ kotlin {
}
val androidMain by getting {
dependsOn(jvmCommonMain)
dependencies {
implementation(libs.androidx.startup.runtime)
}
}
val nonJvmMain by creating {
dependsOn(commonMain)
Expand Down
19 changes: 19 additions & 0 deletions libphonenumber/src/androidMain/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<application>

<provider
android:name="androidx.startup.InitializationProvider"
android:authorities="${applicationId}.androidx-startup"
android:exported="false"
tools:node="merge">

<meta-data
android:name="io.michaelrocks.libphonenumber.kotlin.ApplicationContextInitializer"
android:value="androidx.startup" />
</provider>

</application>
</manifest>
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package io.michaelrocks.libphonenumber.kotlin

import android.content.Context
import androidx.startup.Initializer


internal lateinit var applicationContext: Context

internal class ApplicationContextInitializer : Initializer<Context> {
override fun create(context: Context): Context = context.also {
applicationContext = it
}

override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package io.michaelrocks.libphonenumber.kotlin.metadata

import io.michaelrocks.libphonenumber.kotlin.MetadataLoader
import io.michaelrocks.libphonenumber.kotlin.applicationContext
import io.michaelrocks.libphonenumber.kotlin.metadata.source.AssetsMetadataLoader

actual fun defaultMetadataLoader(context: Any?): MetadataLoader {
return AssetsMetadataLoader((context as android.content.Context).assets)
actual fun defaultMetadataLoader(): MetadataLoader {
return AssetsMetadataLoader(applicationContext.assets)
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ package io.michaelrocks.libphonenumber.kotlin.metadata

import io.michaelrocks.libphonenumber.kotlin.MetadataLoader

expect fun defaultMetadataLoader(context: Any? = null): MetadataLoader
expect fun defaultMetadataLoader(): MetadataLoader
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ package io.michaelrocks.libphonenumber.kotlin.metadata
import io.michaelrocks.libphonenumber.kotlin.MetadataLoader
import io.michaelrocks.libphonenumber.kotlin.metadata.init.MokoAssetResourceMetadataLoader

actual fun defaultMetadataLoader(context: Any?): MetadataLoader {
actual fun defaultMetadataLoader(): MetadataLoader {
return MokoAssetResourceMetadataLoader()
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ package io.michaelrocks.libphonenumber.kotlin.metadata
import io.michaelrocks.libphonenumber.kotlin.MetadataLoader
import io.michaelrocks.libphonenumber.kotlin.metadata.init.ClassPathResourceMetadataLoader

actual fun defaultMetadataLoader(context: Any?): MetadataLoader {
actual fun defaultMetadataLoader(): MetadataLoader {
return ClassPathResourceMetadataLoader()
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ package io.michaelrocks.libphonenumber.kotlin.metadata
import io.michaelrocks.libphonenumber.kotlin.MetadataLoader
import io.michaelrocks.libphonenumber.kotlin.metadata.init.MokoAssetResourceMetadataLoader

actual fun defaultMetadataLoader(context: Any?): MetadataLoader {
actual fun defaultMetadataLoader(): MetadataLoader {
return MokoAssetResourceMetadataLoader()
}
1 change: 0 additions & 1 deletion sample/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ kotlin {
implementation(compose.runtime)
implementation(libs.dev.icerock.moko.resources)
implementation(project(":libphonenumber"))
implementation(project(":libphonenumber-compose"))
}
}

Expand Down
4 changes: 3 additions & 1 deletion sample/src/commonMain/kotlin/App.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ import io.michaelrocks.libphonenumber.kotlin.metadata.defaultMetadataLoader

@Composable
fun App(platform: String) {
val phoneNumberUtil = phoneNumberUtil()
val phoneNumberUtil: PhoneNumberUtil by remember {
mutableStateOf(PhoneNumberUtil.createInstance(defaultMetadataLoader()))
}
var text by remember { mutableStateOf("Hello, World!") }
var examplePhoneNumberToFormat by remember { mutableStateOf("8005551212") }
var examplePhoneNumberFormatted by remember { mutableStateOf(false) }
Expand Down
1 change: 0 additions & 1 deletion settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,5 @@ plugins {
}

include(":libphonenumber")
include(":libphonenumber-compose")
include(":library-test-resources")
include(":sample")

0 comments on commit 95ded84

Please sign in to comment.