Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing 'User-Specific Info' Tutorial to Use ltertools::make_json #13

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Changing 'User-Specific Info' Tutorial to Use ltertools::make_json #13

merged 1 commit into from
Sep 25, 2024

Conversation

njlyon0
Copy link
Member

@njlyon0 njlyon0 commented Sep 20, 2024

See full documentation of the rationale / background work for this change in #12

@njlyon0 njlyon0 self-assigned this Sep 20, 2024
@njlyon0 njlyon0 mentioned this pull request Sep 20, 2024
Closed
7 tasks
angelchen7
angelchen7 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@angelchen7 angelchen7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njlyon0 It LGTM! I think this tutorial is super clear. I was surprised to see that I can already see your newest changes live on our website. The GHA must've triggered for this dev-json2 branch..

@njlyon0 njlyon0 merged commit 9896410 into main Sep 25, 2024
1 check passed
@njlyon0 njlyon0 deleted the dev-json2 branch September 25, 2024 16:55
@njlyon0 njlyon0 added the network-office LTER Network Office (LNO) tasks label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelchen7 angelchen7 angelchen7 approved these changes

Assignees

@njlyon0 njlyon0

Labels
network-office LTER Network Office (LNO) tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njlyon0 @angelchen7