Block account #169
Block account #169
Conversation
|
To discuss: add also the possibility the add a comment while enabling / disabling account |
| @@ -38,7 +44,7 @@ | |||
| } | |||
|
|
|||
| if ($audit_log_file) { | |||
| auditlog($audit_log_file, $dn, $audit_admin, "disableaccount", $result); | |||
| auditlog($audit_log_file, $dn, $audit_admin, "disableaccount", $result, $comment); | |||
There was a problem hiding this comment.
Comment modal is only defined for now in lock/unlock panel in the HTML template.
We may add comment for all action, but this should maybe done in a separate PR.
There was a problem hiding this comment.
Maybe I'll do another PR for the comment feature...
Anyway, the last argument of the function auditlog is needed, else Service-Desk crashes.
htdocs/display.php
Outdated
There was a problem hiding this comment.
Seems some cleaning has to be done, as I forgot to remove OpenLDAP specific code. With the merge of AD support branch, we should have no more any reference to an OpenLDAP specific attribute.
Maybe this should also be part of another PR.
| @@ -38,7 +44,7 @@ | |||
| } | |||
|
|
|||
| if ($audit_log_file) { | |||
| auditlog($audit_log_file, $dn, $audit_admin, "enableaccount", $result); | |||
| auditlog($audit_log_file, $dn, $audit_admin, "enableaccount", $result, $comment); | |||
There was a problem hiding this comment.
Same than previous comment, this need an adaptation of HTML template,
davidcoutadeur
force-pushed
the
125-block-account
branch
from
96cf107 to
c44b3b8
Compare
|
This feature seems ready now. merging |
Closes #125