Remove NetAdapterStop() call

This breaks on Windows 10 when called from EvtCleanupCallback and looks like it doesn't even required - device got deleted and verifier doesn't bark. Bump version to 0.7.3 Signed-off-by: Lev Stipakov <[email protected]>
lstipakov · May 20, 2022 · 8400e9e · 8400e9e
1 parent 6d32753
commit 8400e9e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/PropertySheet.props b/PropertySheet.props
@@ -4,7 +4,7 @@
   <PropertyGroup Label="UserMacros">
     <OVPN_DCO_VERSION_MAJOR>0</OVPN_DCO_VERSION_MAJOR>
     <OVPN_DCO_VERSION_MINOR>7</OVPN_DCO_VERSION_MINOR>
-    <OVPN_DCO_VERSION_PATCH>2</OVPN_DCO_VERSION_PATCH>
+    <OVPN_DCO_VERSION_PATCH>3</OVPN_DCO_VERSION_PATCH>
   </PropertyGroup>
   <PropertyGroup />
   <ItemDefinitionGroup>

diff --git a/adapter.cpp b/adapter.cpp
@@ -119,7 +119,9 @@ OvpnAdapterDestroy(NETADAPTER netAdapter)
     device->Adapter = WDF_NO_HANDLE;
     ExReleaseSpinLockExclusive(&device->SpinLock, irql);
 
-    NetAdapterStop(netAdapter);
+    // TODO: this breaks on Windows 10 when called from EvtCleanupCallback, is this call even needed?
+    // NetAdapterStop(netAdapter);
+
     WdfObjectDelete(netAdapter);
 }