DM-46276: modified wavelength change and setup laser #164
Conversation
There was a problem hiding this comment.
Hi Parker, I added a handful of recommended changes and suggestions to start here. @tribeiro actually looked at most of them together to make sure we were in agreement, so we should be pretty close to finished once these changes are in.
One other missing piece is the unit tests for these methods. The nice part about that though is since they are being unit tested here, you will not need to test them again in the scripts when they are used.
| """Start the propagation of the Tunable Laser""" | ||
| # get laser detailed state | ||
|
|
||
| await self.rem.tunablelaser.cmd_startPropagateLaser.start( |
There was a problem hiding this comment.
How does the propagation work? This might be a good situation to add a check on a evt to check that the propagation has actually started. You can check against the detailedstate evt that the laser is propagating with the right mode before this method completes.
Maybe using something like this
| await self.rem.tunablelaser.cmd_stopPropagateLaser.start( | ||
| timeout=self.long_timeout | ||
| ) | ||
|
|
There was a problem hiding this comment.
Same thing here, you should add a check that the detailed state is nonpropagating before this method completes.
|
|
||
| async def laser_start_propagate(self) -> None: | ||
| """Start the propagation of the Tunable Laser""" | ||
| # get laser detailed state |
There was a problem hiding this comment.
I think you can remove this comment
parfa30
force-pushed
the
tickets/DM-46276
branch
from
55b9b80
to
68589c9
Compare
Changing the laser wavelength and setup laser functions in mtcalsys so are more usable in a variety of sal scripts.