Skip to content

Commit

Permalink
Stop using quotes for main content
Browse files Browse the repository at this point in the history
The original intent of the mrkdwn quote was to emulate the attachments
API's ability to add a coloured bar to content blocks. We don't want to
use attachments because the API is technically deprecated. However,
we've also found that the mrkdwn quote wraps poorly on Slack mobile
views and has done so for many months now and is unlikely to be fixed
upstream. To mitigate this we'll simply remove the quote from
unfurlbot's messages.
  • Loading branch information
jonathansick committed Apr 3, 2024
1 parent eb8399a commit 8fbc5ec
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelog.d/20240403_184036_jsick_DM_43675.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Bug fixes

- Stop using the mrkdwn quote in the main unfurled content because it down't present well in mobile views.
2 changes: 1 addition & 1 deletion src/unfurlbot/services/jiraunfurler.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def format_slack_message(

# The main section block
main_block = SlackTextSectionBlock(
text=(f"> <{issue.homepage}|*{issue.key}*> {issue.summary}"),
text=(f"<{issue.homepage}|*{issue.key}*> {issue.summary}"),
fields=[],
)

Expand Down

0 comments on commit 8fbc5ec

Please sign in to comment.