Restructure file system to enhance readability with multiple APIs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fireye04
commented
Jul 23, 2024
Fireye04
commented
- moved usgs source data from sources.py to sources/usgs_source.py
- sources.py renamed source.py
- moved api specific default values and input checks to scripts/usgs.py
Fireye04
force-pushed
the
u/kaikoehler/restructure
branch
3 times, most recently
from
620db1a to
106a040
Compare
|
Hey just requesting a review to check if the restructure I just did is good. The goal was to have as little overlap between different APIs. Post refactor, the only overlap is in the |
Fireye04
force-pushed
the
u/kaikoehler/restructure
branch
from
5740204 to
1208926
Compare
Fireye04
force-pushed
the
u/kaikoehler/restructure
branch
from
2a7bebb to
03678f9
Compare
|
Is this PR still valid or is superseded by #25? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.