feat: support NOIRLab announcements #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgoff
commented
Oct 28, 2024
| contacts: Array<ReleaseContact> | (string | undefined); | ||
| } | ||
|
|
||
| const Contacts: FunctionComponent<ContactsProps> = ({ contacts = [] }) => { |
There was a problem hiding this comment.
revamp the Contacts component, announcements send their contacts as an HTML chunk instead of an array. Display will be slightly different between press releases and announcements because of this.
|
|
||
| if (pressReleaseId) { | ||
| // Announcements | ||
| if (slug !== "feature" && pressReleaseId) { |
There was a problem hiding this comment.
add a second server data fetch to the news page if this is detected as an announcement
ericdrosas87
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #598
Add support for NOIRLab announcements to news pages and to the SWR data mixer.
To test: