[F] Inline questions #71
Conversation
alexgoff
added
enhancement
| @@ -35,7 +35,12 @@ export default async function saveAnswers( | |||
| return "statusError"; | |||
| } | |||
|
|
|||
| const answerSet = Object.values(answers); | |||
| const answerSet = Object.values(answers).map(({ data, ...values }) => { | |||
There was a problem hiding this comment.
@kylepratuch I wanted your input here on stringifying the data property before putting it into the query. We talked about the DB storing all values as a string type, since the typing of data is very loose for the different question types (it can be a string, array of strings, generic object, mildly typed object), I opted to stringify all the data rather than trying to adapt the limited GQL types to fit.
There was a problem hiding this comment.
@alexgoff I'm not experienced enough with typescript to know at a glance if this is going to do what we discussed, but I trust that you do. :) Generally, I don't see an issue consistently storing the Answer data field as strings of JSON since that's really just supposed to consist of the values provided by users. If you start needing to store additional attributes beyond just the given answer values it might be worth adding some additional fields to the Answer element instead.
| onChangeCallback={(value: string | string[]) => | ||
| onChangeCallback && | ||
| onChangeCallback( | ||
| { ...(data as InlineQuestionData), [partId]: value }, |
There was a problem hiding this comment.
updates the data object with a value using the inline question part's ID as the key.
| } | ||
| `; | ||
|
|
||
| export const QuestionLabel = styled.div` |
There was a problem hiding this comment.
co-locate these styles with the SimpleQuestion component so they don't pollute the inline questions
For JIRA: "EPO-8591 #IN-REVIEW #comment Multi-part question type"
|
A preview of this PR will be available at https://epo8591-dot-investigations-client-dot-skyviewer.appspot.com until the request is closed. |
JIRA: https://jira.lsstcorp.org/browse/EPO-8593
What this change does
Adds client wire up for inline questions, includes new typings for stored answers and some changes to how answers are sent to the server (as JSON)
Notes for reviewers
Use the new database uploaded to dumps on 10/30 and check the inline questions (pg. 10 is a good starting point), and verify them as well in Craft that the entries can be created, saved, and added to pages.
Include an indication of how detailed a review you want on a 1-10 scale.
Testing
Checklist
If any of the following are true, please check them off
/src/data/pages/PAGE.json) or scientific data (anything in/static/) and I will notify Product Marketing when it is in prod and user visible.Screenshots (optional)
Before:
After: